[Logging] Fix and standardize timestamp formats across Cloudwatch log configurations. #3071
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
changed the title
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-cw-log-timestamp-1215-1
branch
from
a50c468 to
d286e41
Compare
… configurations. - Rename timestamp format keys to use consistent naming convention (iso8610, default_seconds) - Update CloudWatch agent config to use iso8610 format for JSON event logs (clustermgtd, slurm_resume) - Consolidate Slurm log timestamp formats (slurmd, slurmctld, slurmdbd) to use iso8610 - Update SSSD log timestamp format from default to default_seconds for consistency - Change DCV authenticator log format from bracket_default to default - Add millisecond precision to PS4 prompt in generate_ssh_key.sh for better debug logging - Add millisecond precision to pcluster_dcv_connect.sh log timestamps for improved log accuracy - Improves log parsing consistency and debugging capabilities across all services
gmarciani
changed the title
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-cw-log-timestamp-1215-1
branch
from
d286e41 to
52f0d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix and consolidate the timestamp format used for CW Logs in CW Agent configuration. In particular, the following changes have been applied:
- Rename timestamp format keys to use consistent naming convention (iso8610, default_seconds)
- Update CloudWatch agent config to use iso8610 format for JSON event logs (clustermgtd, slurm_resume)
- Consolidate Slurm log timestamp formats (slurmd, slurmctld, slurmdbd) to use iso8610
- Update SSSD log timestamp format from default to default_seconds for consistency
- Change DCV authenticator log format from bracket_default to default
- Add millisecond precision to PS4 prompt in generate_ssh_key.sh for better debug logging
- Add millisecond precision to pcluster_dcv_connect.sh log timestamps for improved log accuracy
- Improves log parsing consistency and debugging capabilities across all services
Tests
test_cloudwatch_loggingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.